fix: update pcre2 pattern for android (#5441) #5447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pattern to detect libpcre2 version in Android libraries where the version string format differs from standard Linux binaries. - Add FILENAME_PATTERNS to match pcre2 library files - Add VERSION_PATTERNS for Android format with version+date and "this version of PCRE2" error message as anchor - Add test case for Android libpcre2 format Signed-off-by: Jack <[email protected]>
Add support for detecting pcre2 versions in Android binaries which use null byte separators instead of newlines. Each Android API version has different string layouts requiring separate patterns. Tested on Android APIs 28, 29, 30, and 34. Signed-off-by: Jack <[email protected]>
jackulau
force-pushed
the
5441_libpcre2
branch
from
d88515b to
da69ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pattern to detect libpcre2 version in Android libraries where the version string format differs from standard Linux binaries.
Summary
Addresses #5441 - Android libpcre2 library not detected by CVE-bin-tool.
FILENAME_PATTERNSto match pcre2 library filesVERSION_PATTERNSto detect version in Android binariesDetails
The existing pattern required
BSR_UNICODE)to be immediately followed by the version number, which is not the case in Android binaries. In Android'slibpcre2.so, the version string (e.g.,10.33 2019-04-16) appears standalone between other PCRE2 option strings.New patterns added:
These match the PCRE2 version+date format (MAJOR.MINOR YYYY-MM-DD) using adjacent PCRE2-specific strings as anchors.
Test plan