Skip to content

Conversation

@jackulau
Copy link


Summary

  • Add FILENAME_PATTERNS for pppopptp to detect Android's pppopptp-android.so library
  • Add CONTAINS_PATTERNS for pppd_version marker used in Android binaries
  • Add VERSION_PATTERN for null-terminated version strings (\x00\x00\x00)
  • Add test case for Android pppopptp v2.4.7

Test plan

  • Tested on Android API 28 (library not present - expected)
  • Tested on Android API 29 - version 2.4.7 detected
  • Tested on Android API 30 - version 2.4.7 detected
  • Tested on Android API 34 - version 2.4.7 detected

@ffontaine
Copy link
Collaborator

There is already a PR for ppp (#5450), and the new pattern with the three NULL bytes will probably raise a lot of false positives.

@jackulau
Copy link
Author

Good catch, did not see that.

@jackulau jackulau closed this Dec 12, 2025
@jackulau jackulau deleted the 5441_pppopptp branch December 13, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants