-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency/SBOM criteria and releveling #163
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to adjust the xls to account for this change, but +1
baseline/OSPS-QA.yaml
Outdated
language dependency lock file that ennumerates all | ||
direct and transitive dependencies such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details says "direct and transitive" but criteria says "direct". Which do we require here?
@SecurityCRob I'm happy to add it to the spreadsheet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the first entry needs to be changed to follow our criterion format
This commit updates the dependency criteria to add increasing transparency requirements at each level. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should soften the language in the rationale/details to make it clear that what we're looking for in this criterion is enumeration, not pinning.
On the other hand, if we do want to require some form of pinning at level 1, we need to
- Update the criterion text to include that
- Specify what sort of pinning is sufficient (e.g. minimum version, branch/release name, specific version, hash, etc etc etc)
For clarity: my strong preference is to go with the first approach and focus on enumeration at level 1.
I'll figure this out today, no worries! |
Co-authored-by: Ben Cotton <[email protected]> Signed-off-by: CRob <[email protected]>
Co-authored-by: Ben Cotton <[email protected]> Signed-off-by: CRob <[email protected]>
This commit updates the dependency criteria to add increasing transparency requirements at each level:
In addition to the two new ones, OSPS-QA-03 is simplified and releveled to 1.
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]