Skip to content

Don't erase elements if multiple subscriptions use them #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilativ-dotcom wants to merge 18 commits into
base: main
Choose a base branch
from

[memory][core][events][tests] Duplicate TODO in tests

b375f96
Select commit
Loading
Failed to load commit list.
Open

Don't erase elements if multiple subscriptions use them #425

[memory][core][events][tests] Duplicate TODO in tests
b375f96
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded May 1, 2025 in 0s

97.63% of diff hit (target 95.70%)

View this Pull Request on Codecov

97.63% of diff hit (target 95.70%)

Annotations

Check warning on line 220 in sc-memory/sc-core/src/sc-store/sc-event/sc_event_queue.c

See this annotation in the file changed.

@codecov codecov / codecov/patch

sc-memory/sc-core/src/sc-store/sc-event/sc_event_queue.c#L217-L220 

Added lines #L217 - L220 were not covered by tests

Check warning on line 256 in sc-memory/sc-core/src/sc-store/sc-event/sc_event_queue.c

See this annotation in the file changed.

@codecov codecov / codecov/patch

sc-memory/sc-core/src/sc-store/sc-event/sc_event_queue.c#L255-L256 

Added lines #L255 - L256 were not covered by tests

Check warning on line 65 in sc-memory/sc-core/src/sc-store/sc_event_subscription.c

See this annotation in the file changed.

@codecov codecov / codecov/patch

sc-memory/sc-core/src/sc-store/sc_event_subscription.c#L64-L65 

Added lines #L64 - L65 were not covered by tests

Check warning on line 212 in sc-memory/sc-core/src/sc-store/sc_event_subscription.c

See this annotation in the file changed.

@codecov codecov / codecov/patch

sc-memory/sc-core/src/sc-store/sc_event_subscription.c#L212 

Added line #L212 was not covered by tests

Check warning on line 854 in sc-memory/sc-core/src/sc-store/sc_storage.c

See this annotation in the file changed.

@codecov codecov / codecov/patch

sc-memory/sc-core/src/sc-store/sc_storage.c#L854 

Added line #L854 was not covered by tests

Check warning on line 880 in sc-memory/sc-core/src/sc-store/sc_storage.c

See this annotation in the file changed.

@codecov codecov / codecov/patch

sc-memory/sc-core/src/sc-store/sc_storage.c#L880 

Added line #L880 was not covered by tests
View more details on Codecov