-
Notifications
You must be signed in to change notification settings - Fork 27
Clang format #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang format #9
Conversation
06e0fe0 to
c14de01
Compare
KovalM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add check formatting to CI, script for only check formatting. Look to source PR, this changes are presented there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format-code.py seems a bit redundant. What do you think about a CMake integration? Something like this
f66563e to
48ce715
Compare
KovalM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add information about using code check to docs
- Add setup pre-push hooks for code check. Add to docs info about install hooks
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage ? 57.77%
=======================================
Files ? 30
Lines ? 3706
Branches ? 0
=======================================
Hits ? 2141
Misses ? 1565
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
FallenChromium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a major problem with this approach:
cd build
cmake ..
makeFirst, it changes the current directory which is undesirable. Second, it relies on make rather than CMake only, so if we're going to switch the build system someday (say cmake -G Ninja), our docs will be obsolete. I have a proposal: let's make this build command a standard:
cmake -B build
cmake --build build
It's shorter, only relies on CMake and it doesn't do the cd. If we'll adopt this approach in this PR, I'll make another one to redact it in the remaining places. I am not asking about this out of purely aesthetics reasons, look at what happened on my machine, for example:

I already have a build folder, but that shouldn't be a problem! If the script just used build as a target directory through cmake, rather than trying to create it manually, that would've passed.
I've also sent some minor notes about the documentation, but other than the problem stated above and docs changes, it looks good to me! The formatting rules themselves are a subject of discussion, personally I don't like how it looks, but it's very subjective so I'm not going to bring this up unless someone else wants to elaborate on the topic.
FallenChromium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! We could get rid of other pushd/popd or cd/cd .. logic too while we're at it, but it's unnecessary to do it in this PR.
chapter_top_ontologies added
Moved pr