Repository navigation
Audit what an exec's command did - #146
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141, found by the otter_cloud contract test against v0.17.1.
The bug
POST /api/jails/{name}/execwas audited through the generic step logger. That records only Jail Deck's own failure to run a command. So an exec that ran was always written assuccess: true, exit_code: 0, with notimed_out, whatever the command did. The audit log couldn't say a command failed or was killed, which is the one question exec is audited to answer.The fix
200). It now carries the command's ownexit_code,timed_outandduration_ms.duration_msappears on exec entries too.Checked
make checkpasses.The audit output changes for exec entries; the next release's CHANGELOG will say so under API.
🤖 Generated with Claude Code