Change 'requires' to 'install_requires' in setup.py #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime dependencies should be in "install_requires". "requires" is for build dependencies. Otherwise, the "requests" package won't correctly be installed when running "pip install python-powerdns" in a clean environment:
```
Python 3.10.12 (main, Aug 15 2025, 14:32:43) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import powerdns
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/romain/.../venv/lib/python3.10/site-packages/powerdns/__init__.py", line 26, in <module>
from .client import PDNSApiClient
File "/home/romain/.../venv/lib/python3.10/site-packages/powerdns/client.py", line 27, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
```
Reference: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#declaring-required-dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime dependencies should be in "install_requires". "requires" is for build dependencies. Otherwise, the "requests" package won't correctly be installed when running "pip install python-powerdns" in a clean environment:
Reference