Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node/fs): add test-fs-rm.js #16809

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 27, 2025

What does this PR do?

Adds parallel/test-fs-rm.js

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

This PR only adds a test.

@robobun
Copy link

robobun commented Jan 27, 2025

Updated 2:49 PM PT - Jan 27th, 2025

@DonIsaac, your commit 51fc28a has 2 failures in Build #10653:


🧪   try this PR locally:

bunx bun-pr 16809

Copy link
Contributor Author

DonIsaac commented Jan 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac requested a review from paperclover January 27, 2025 21:58
@DonIsaac DonIsaac added the node:fs label Jan 27, 2025 — with Graphite App
@DonIsaac DonIsaac marked this pull request as ready for review January 27, 2025 21:58
@DonIsaac DonIsaac force-pushed the 01-27-test_node_fs_add_test-fs-rm.js_ branch from cb713e5 to 51fc28a Compare January 27, 2025 22:01
paperclover
paperclover previously approved these changes Jan 27, 2025
@RiskyMH
Copy link
Member

RiskyMH commented Jan 28, 2025

image

of course windows has to be no fun
https://buildkite.com/bun/bun/builds/10653

or... is this fixed in above linked #16806

Base automatically changed from don/fix/fs-dir to main January 28, 2025 21:38
@paperclover paperclover dismissed their stale review January 28, 2025 21:38

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants