-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove unnecessary steps & cleanup #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all unnecessary changes - keep quotes, remove emojis.
i agree with removing gh cli installation and inlining the run step if there's only one command
Why keep the quotes? I'm against this, I want them to be only where they are needed |
Regarding emojis - I want them to be at least in the Workflow name, because then it's much easier to navigate them |
Personally, I use them in step names because it's easier for me to navigate, but if you stick to the emoji-free style, then it's ok |
I would keep them everywhere for consistency.
I don't see any reason for having emojis in the workflow name; it doesn't improve navigation. |
Then please - add them if you so want them |
I don't understand why you didn't do it earlier |
Okay, we can keep your changes but we should also change name of the |
I see that it is written there that it must be specifically called as There are two options:
|
Oh, you're right! Well we can do the second thing but probably in different pull request since it's out of scope. |
Ok 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
No description provided.