fix: allow installing custom openedx-scorm-xblock using the openedx-dockerfile-post-python-requirements patch
#1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ockerfile-post-python-requirements patch The openedx-scorm-xblock was inconveniently being installed right after this patch was defined This meant that the only way to install a custom scorm-xblock was to use the OPENEDX_EXTRA_PIP_REQUIREMENTS setting which is not as convenient as the patch.
DawoudSheraz
approved these changes
Feb 4, 2025
Danyal-Faheem
deleted the
danyal/allow-installing-scorm-xblock-using-patch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openedx-scorm-xblock was inconveniently being installed right after this patch was defined.
This meant that the only way to install a custom scorm-xblock was to use the OPENEDX_EXTRA_PIP_REQUIREMENTS setting which is not as convenient as the patch itself.