Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

committing changes related to Visa permissions schema #688

Merged
merged 1 commit into from
Apr 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/bio/overture/ego/controller/VisaController.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ public VisaController(
this.applicationPermissionService = applicationPermissionService;
}

/*
* This method is used to fetch visa using id
* @param id UUID
* @return visa Visa
*/
@AdminScoped
@RequestMapping(method = GET, value = "/{id}")
@ApiResponses(
Expand Down
9 changes: 9 additions & 0 deletions src/main/java/bio/overture/ego/model/entity/Visa.java
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
package bio.overture.ego.model.entity;

import static com.google.common.collect.Sets.newHashSet;

import bio.overture.ego.model.enums.JavaFields;
import bio.overture.ego.model.enums.SqlFields;
import bio.overture.ego.model.enums.Tables;
import bio.overture.ego.view.Views;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
import com.fasterxml.jackson.annotation.JsonView;
import java.util.Set;
import java.util.UUID;
import javax.persistence.*;
import javax.validation.constraints.NotNull;
Expand Down Expand Up @@ -58,4 +62,9 @@ public class Visa implements Identifiable<UUID> {
@JsonView({Views.JWTAccessToken.class, Views.REST.class})
@Column(name = SqlFields.BY)
private String by;

@JsonIgnore
@ManyToMany(mappedBy = "visaId", cascade = CascadeType.ALL, fetch = FetchType.LAZY)
@Builder.Default
private Set<VisaPermission> visaPermissions = newHashSet();
}
62 changes: 62 additions & 0 deletions src/main/java/bio/overture/ego/model/entity/VisaPermission.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package bio.overture.ego.model.entity;

import static bio.overture.ego.model.enums.AccessLevel.EGO_ACCESS_LEVEL_ENUM;

import bio.overture.ego.model.enums.AccessLevel;
import bio.overture.ego.model.enums.SqlFields;
import bio.overture.ego.model.enums.Tables;
import bio.overture.ego.view.Views;
import com.fasterxml.jackson.annotation.JsonView;
import java.util.Collection;
import java.util.UUID;
import javax.persistence.*;
import javax.validation.constraints.NotNull;
import lombok.*;
import lombok.experimental.FieldNameConstants;
import org.hibernate.annotations.GenericGenerator;
import org.hibernate.annotations.Type;

@Entity
@Table(name = Tables.ACLVISAPERMISSION)
@Data
@Builder
@NoArgsConstructor
@AllArgsConstructor
@JsonView(Views.REST.class)
@ToString(callSuper = true)
@FieldNameConstants
public class VisaPermission extends AbstractPermission<Visa> {

@Id
@Column(name = SqlFields.ID, updatable = false, nullable = false)
@GenericGenerator(name = "aclp_uuid", strategy = "org.hibernate.id.UUIDGenerator")
@GeneratedValue(generator = "aclp_uuid")
private UUID id;

@JoinColumn(name = SqlFields.ID, nullable = false)
private UUID entity;

@JoinColumn(name = SqlFields.ID, nullable = false)
private UUID visaId;

@NotNull
@Column(name = SqlFields.MASK, nullable = false)
@Enumerated(EnumType.STRING)
@Type(type = EGO_ACCESS_LEVEL_ENUM)
private AccessLevel mask;

@ManyToMany
@JoinTable(
name = "ga4ghvisa",
joinColumns = @JoinColumn(name = "aclp_id", referencedColumnName = "visaId"),
inverseJoinColumns = @JoinColumn(name = "visa_id", referencedColumnName = "id"))
private Collection<Visa> visas;

@Override
public Visa getOwner() {
return null;
}

@Override
public void setOwner(Visa owner) {}
}
2 changes: 2 additions & 0 deletions src/main/java/bio/overture/ego/model/enums/JavaFields.java
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,6 @@ public class JavaFields {
public static final String VALUE = "value";

public static final String BY = "by";

public static final String VISAPERMISSION = "ACLVISAPERMISSION";
}
6 changes: 6 additions & 0 deletions src/main/java/bio/overture/ego/model/enums/SqlFields.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,10 @@ public class SqlFields {
public static final String VALUE = "value";

public static final String BY = "by";

public static final String ENTITY = "entity";

public static final String VISAID = "visaId";

public static final String MASK = "mask";
}
2 changes: 2 additions & 0 deletions src/main/java/bio/overture/ego/model/enums/Tables.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ public class Tables {
public static final String INITTRIPWIRE = "inittripwire";

public static final String GA4GHVISA = "ga4ghvisa";

public static final String ACLVISAPERMISSION = "ACLVISAPERMISSION";
}
16 changes: 16 additions & 0 deletions src/main/java/bio/overture/ego/service/VisaPermissionService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package bio.overture.ego.service;

import bio.overture.ego.model.entity.*;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

@Slf4j
@Service
@Transactional
public class VisaPermissionService {

/** Dependencies */
@Autowired private VisaService visaService;
}
10 changes: 5 additions & 5 deletions src/main/java/bio/overture/ego/service/VisaService.java
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ public void delete(@NonNull UUID id) {
super.delete(id);
}

@Override
public Visa getWithRelationships(UUID uuid) {
return null;
}

public Page<Visa> listVisa(@NonNull Pageable pageable) {
return visaRepository.findAll(pageable);
}
Expand All @@ -88,4 +83,9 @@ public abstract static class VisaConverter {

public abstract void updateVisa(VisaUpdateRequest request, @MappingTarget Visa visaToUpdate);
}

@Override
public Visa getWithRelationships(UUID uuid) {
return null;
}
}
8 changes: 8 additions & 0 deletions src/main/resources/flyway/sql/V1_23__add_visa_pcl.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
CREATE TABLE ACLVISAPERMISSION (
id UUID PRIMARY KEY,
entity UUID,
visaId UUID,
mask ACLMASK NOT NULL,
FOREIGN KEY (entity) REFERENCES POLICY(id),
FOREIGN KEY (visaId) REFERENCES GA4GHVISA(id)
);