Merged
Conversation
leoraba
reviewed
May 31, 2024
libraries/dictionary/package.json
Outdated
| "scripts": { | ||
| "build": "pnpm build:clean && tsc", | ||
| "build:clean": "rm -rf dist/ && mkdir dist", | ||
| "build:clean": "rimraf -rf dist/ && mkdir dist", |
Contributor
There was a problem hiding this comment.
no need arguments -rf when using rimraf
leoraba
reviewed
May 31, 2024
libraries/common/package.json
Outdated
| "scripts": { | ||
| "build": "pnpm build:clean && tsc", | ||
| "build:clean": "rm -rf dist/ && mkdir dist" | ||
| "build:clean": "rimraf -rf dist/ && mkdir dist" |
Contributor
There was a problem hiding this comment.
no need arguments -rf when using rimraf
leoraba
approved these changes
May 31, 2024
Contributor
leoraba
left a comment
leoraba
left a comment
There was a problem hiding this comment.
just left a comment overall LGTM
joneubank
commented
Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the existing Lectern Client code into this monorepo. Previously this was written and maintained in overture-stack/js-lectern-client. This code will now be maintained in the same directory as the Lectern server so that types and utilities can be shared.
The code added in this request includes a mostly unchanged copy/paste of the lectern client in its most up to date form. A small list of changes were made to make it align with the processes of this repository, including:
/libto/distThis accomplishes the base goals of: #206 , but does not touch the refactoring tasks such as updating the client to use the same types as the server.