export validation error type #229
Merged
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no problem with this, but I wonder if we should also export more error details. A similar need could arise from the response to the other validation functions. For example:
|
joneubank
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Let's be consistent and export error details from more of the responses. I listed the others here: #229 (comment)
|
Added additional types to export. |
joneubank
approved these changes
Sep 19, 2024
|
Reviewing why the Jenkins CI tests are failing - errors are not caused by the changes in this PR... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix Issue #230
To be able to export type
DictionaryValidationRecordErrorDetailson package@overture-stack/lectern-client