Remove unused imports and unnecessary if statement #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used LGTM (https://lgtm.com/projects/g/overviewer/Minecraft-Overviewer/?mode=list&id=py%2Funnecessary-pass%2Cpy%2Funused-import) to find unused imports also removed unnecessary if statement in "overviewer_core/textures.py". The if statement just had a "pass" statement which makes it redundant
|
Any updates regarding this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used LGTM to find unused imports, now removed.
I also removed an unnecessary if-statement in
overviewer_core/textures.py. The if statement just had a "pass" statement which makes it redundant(this pull request is very similar to #1686 which I closed due to conflicts).