Skip to content

fix: honor ENABLE_KVCACHED in autopatch enable check#322

Closed
cui36 wants to merge 1 commit intomainfrom
fix/autopatch-env-control
Closed

fix: honor ENABLE_KVCACHED in autopatch enable check#322
cui36 wants to merge 1 commit intomainfrom
fix/autopatch-env-control

Conversation

@cui36
Copy link
Copy Markdown
Collaborator

@cui36 cui36 commented May 3, 2026

To solve the issue #320, #317 and #316, by setting kvcached using unified arg ENABLE_KVCACHED.

@cui36 cui36 requested a review from jiarong0907 May 3, 2026 04:13
@jiarong0907
Copy link
Copy Markdown
Collaborator

def _env_enabled() -> bool:
    return os.getenv("KVCACHED_AUTOPATCH", "false").lower() in ("true", "1")
    return (
        os.getenv("ENABLE_KVCACHED", "false").lower() in ("true", "1")
        or os.getenv("KVCACHED_AUTOPATCH", "false").lower() in ("true", "1")
    )

Not sure this is a good design because enabling kvcached is separated from enabling autopath. I can imagine someone manually integrates kvcached with vLLM and thus doesn't need our autopatching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants