feat(zimbra): manage new advanced settings fields in create/update email #20615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atefzed
reviewed
Nov 26, 2025
packages/manager/apps/zimbra/src/pages/dashboard/emailAccounts/EmailAccountForm.component.tsx
Outdated
Show resolved
Hide resolved
atefzed
reviewed
Nov 26, 2025
packages/manager/apps/zimbra/src/pages/dashboard/emailAccounts/EmailAccountForm.component.tsx
Outdated
Show resolved
Hide resolved
atefzed
reviewed
Nov 26, 2025
packages/manager/apps/zimbra/src/pages/dashboard/emailAccounts/EmailAccountForm.component.tsx
Show resolved
Hide resolved
atefzed
reviewed
Nov 26, 2025
packages/manager/apps/zimbra/src/pages/dashboard/emailAccounts/EmailAccountForm.component.tsx
Outdated
Show resolved
Hide resolved
amine-daoussi
force-pushed
the
feat/PRDCOL-268
branch
from
6f505bd to
2a233cb
Compare
ref: #PRDCOL-268 Signed-off-by: amine-daoussi <[email protected]>
amine-daoussi
force-pushed
the
feat/PRDCOL-268
branch
from
2a233cb to
6be87e1
Compare
atefzed
approved these changes
Nov 27, 2025
kb-ovh
reviewed
Nov 28, 2025
| ): AccountBodyParamsType => { | ||
| const { account, domain, slotId, password } = data; | ||
| const { account, domain, slotId, password, contactInformation } = data; | ||
| const safeContactInformation = { |
Contributor
There was a problem hiding this comment.
Why not move this code into the hook that makes the API call? This would make the code more readable and agnostic of the API's subtleties
kb-ovh
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #PRDCOL-268
Description