feat(backup-agent): add backup agent deletion #20636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovh
requested review from
aboungnaseng-ovhcloud,
anooparveti and
helabenkhalfallah
and removed request for
a team
tibs245
reviewed
Nov 26, 2025
packages/manager/modules/backup-agent/src/data/api/agents/agents.requests.ts
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Nov 26, 2025
packages/manager/modules/backup-agent/src/data/hooks/agents/useDeleteAgent.ts
Show resolved
Hide resolved
tibs245
reviewed
Nov 26, 2025
packages/manager/modules/backup-agent/src/utils/buildSearchQuery.utils.ts
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Nov 26, 2025
tibs245
requested changes
Nov 26, 2025
Contributor
tibs245
left a comment
tibs245
left a comment
There was a problem hiding this comment.
Missing one integration test to see if modal if visible on good link
Missing units tests for utils
Can have one unit test to see if page is accessible and if we handle the mutation on click of delete
Can be improved with a unit test if the request not work (Agent already deleted) and see error
tibs245
reviewed
Nov 26, 2025
packages/manager/modules/backup-agent/public/translations/services/listing/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
vovh
force-pushed
the
feat/BKP-503-delete-agent
branch
from
8e57dd5 to
10c2ba8
Compare
tibs245
reviewed
Nov 28, 2025
...p-agent/src/pages/services/dashboard/agent/delete/__tests__/DeleteAgent.integration.test.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Nov 28, 2025
...p-agent/src/pages/services/dashboard/agent/delete/__tests__/DeleteAgent.integration.test.tsx
Outdated
Show resolved
Hide resolved
tibs245
reviewed
Nov 28, 2025
packages/manager/modules/backup-agent/src/data/hooks/agents/useDeleteAgent.ts
Show resolved
Hide resolved
tibs245
reviewed
Nov 28, 2025
...s/backup-agent/src/pages/services/dashboard/agent/_components/AgentActionsCell.component.tsx
Show resolved
Hide resolved
tibs245
reviewed
Nov 28, 2025
vovh
force-pushed
the
feat/BKP-503-delete-agent
branch
2 times, most recently
from
093c14d to
635fe1a
Compare
github-actions
bot
added
the
has conflicts
ref: BKP-503 Signed-off-by: Vincent Bonmarchand <[email protected]>
vovh
force-pushed
the
feat/BKP-503-delete-agent
branch
from
635fe1a to
d73e995
Compare
github-actions
bot
removed
the
has conflicts
tibs245
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: BKP-503
Description
Ticket Reference: #...
Additional Information