Windows build, fixed duplicate YAJL dir in script #1612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
enhancement
RIP - Type - Config Improvement
2.x
victorhora
added a commit
that referenced
this pull request
Nov 4, 2018
|
Confirm it fixes the issue with the automated build script. We might need to adjust the Windows buildbot builds scripts to take this into consideration. |
|
Merged at e97799c Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Felipe. I see you recently did this change c917df0 , but I think there might be a problem with the YAJL path. When building via build_modsecurity.bat directly, all is fine, because the path becomes ....\yajl\build\yajl-2.1.0 . But when building via build_release.bat , build_yajl.bat gets invoked, which sets the YAJL_DIR env variable, and so the path becomes ....\yajl\build\yajl-2.1.0\yajl-2.1.0 and the build fails.
Changing build_modsecurity.bat to let YAJL align with the other dependencies, where only the %DEPENDENCIES_DIR% env variable is used, and the rest is hardcoded.