Skip to content
This repository was archived by the owner on Jul 24, 2018. It is now read-only.

[WIP] Annotations #274

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[WIP] Annotations #274

wants to merge 12 commits into from

Conversation

VicDeo
Copy link
Contributor

@VicDeo VicDeo commented Jun 11, 2014

No description provided.

@karlitschek
Copy link

looks good 👍

@adityab
Copy link
Contributor

adityab commented Jun 11, 2014

localeditor.js is just a reference file, you should copy it and make something like revieweditor.js with your own customizations (if needed). You'll also need to feed the Editor your own operation router, one that will ensure that:

  1. No other member enters the session.
  2. Edits are persisted to the server without explicit saving, just like in the regular editor.
  3. A member with the correct information is added.

Perhaps you can just reuse your existing server backend with the constraint of 2. applied.

// start the editor
booting = true;

editorOptions.reviewModeEnabled = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the concept of a 'session' and the memberListView are tied together, there is no avoiding the member list construction for now. So I suggest adding another line editorOptions.collabEditingEnabled = true;, and then hiding the Member List through CSS.

@jancborchardt
Copy link
Contributor

@VicDeo any update here, is this ready for review? Can you rebase before?

@VicDeo VicDeo force-pushed the master branch 3 times, most recently from d8b54e6 to 228d92d Compare October 3, 2014 21:22
@jospoortvliet
Copy link

with the new version being merged, isn't this in already? ;-)

@VicDeo
Copy link
Contributor Author

VicDeo commented Jun 18, 2015

@jospoortvliet not exactly. This is about review only mode as per #270

@jospoortvliet
Copy link

ah, ok, that's a cool feature!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants