-
Notifications
You must be signed in to change notification settings - Fork 184
feat: [OCISDEV-249] add MFA capability #12925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
A couple of important things:
owncloud/ocis#11603 has some information about the expected behavior of the clients regarding the feature detection. |
@jvillafanez the values are hardcoded for now just for testing. They will be replaced once the capabilities are implemented as per the ticket:
|
Depending on the headers might prove very complex in the FE because we might have different situations where e.g. there is an action in progress which needs to be preserved until the user goes through OTP, etc. Since it's not only about handling a common redirect and nothing more, doing a generic handler depending on the header would then require bloated catch-all solution for such specific situations + we might have cases where we need to display things differently within the UI which would not be possible if we would have to first do a request... That being said, we should of course have at least a simple fallback implemented which does the redirect in case we encounter those headers so that we catch any potential error or missing implementation. One more thing is that we would temporarily show the UI of admin in a loading state if we would wait for the response. |
a15c1c5
to
316cde3
Compare
We've added a capability to check if MFA is enabled. If the capability is enabled, we will require MFA when accessing the admin settings page.
006af87
to
77be8c5
Compare
|
Description
We've added a capability to check if MFA is enabled. If the capability is enabled, we will require MFA when accessing the admin settings page.
Motivation and Context
Admin settings can be made available only to users with configured 2FA.
How Has This Been Tested?
For easier testing, there is a Keycloak example with acr configured introduced in owncloud/ocis#11592 and currently oCIS needs to be run with owncloud/ocis#11603 and latest Reva.
Types of changes