[POC][tests-only] e2e tests with Playwright only #12941

Ashim-Stha · 2025-08-20T09:30:35Z

Description

Rewrite the old Cucumber test from tests/e2e/cucumber/features/shares/internalLink.feature with a new Playwright test at tests/spec/internalLink.spec.ts

Related Issue

#12938

Run test

To run test locally in chromium in headed mode

NODE_TLS_REJECT_UNAUTHORIZED=0 npx playwright test -g "opening a link with internal role" --config=tests/e2e-playwright/ --project=chromium --headed

CLAassistant · 2025-08-20T09:30:41Z

All committers have signed the CLA.

saw-jan · 2025-08-25T11:08:20Z

@Ashim-Stha Could you edit the PR title to something like this?
[POC][tests-only] e2e tests with Playwright only

Ashim-Stha · 2025-08-25T11:15:28Z

@Ashim-Stha Could you edit the PR title to something like this? [POC][tests-only] e2e tests with Playwright only

done 👍

playwright.config.ts

tests/e2e-playwright/helper/api.ts

tests/e2e-playwright/helper/setAccessAndRefreshToken.ts

saw-jan · 2025-09-01T06:37:06Z

tests/e2e/support/api/davSpaces/spaces.ts

@@ -3,7 +3,7 @@ import { User } from '../../types'
 import join from 'join-path'
 import { getSpaceIdBySpaceName } from '../graph'
 import convert from 'xml-js'
-import _ from 'lodash-es/object'
+import _ from 'lodash-es/object.js'


why do we need this change?

we get this error when running playwright test

Error: Cannot find module '/var/www/owncloud/web/tests/e2e/node_modules/lodash-es/object' imported from /var/www/owncloud/web/tests/e2e/support/api/davSpaces/spaces.ts Did you mean to import "lodash-es/object.js"? Error: No tests found

tests/e2e/run-e2e.sh

Signed-off-by: Ashim Shrestha <[email protected]>

sonarqubecloud · 2025-09-02T05:51:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Ashim-Stha · 2025-09-02T06:11:47Z

can you run this on drone

done

saw-jan · 2025-09-05T04:22:52Z

.drone.star

+        "HEADLESS": "true",
+        "RETRY": "1",
+        "BASE_URL_OCIS": "ocis:9200",
+        "FAIL_ON_UNCAUGHT_CONSOLE_ERR": "true",
+        "PLAYWRIGHT_BROWSERS_PATH": ".playwright",
+        "BROWSER": "chromium",
+        "FEDERATED_BASE_URL_OCIS": "federation-ocis:9200",


most of these are not in use. need to update playwright accordingly.

saw-jan · 2025-09-05T04:24:07Z

.drone.star

+    steps += tikaService() + \
+             ocisService()


we should add tika once the search e2e tests are added

Suggested change

steps += tikaService() + \

ocisService()

steps += ocisService()

saw-jan · 2025-09-05T04:25:31Z

package.json

@@ -12,6 +12,7 @@
    "lint": "eslint vite.config.ts '{packages,tests}/**/*.{js,ts,vue}' --color",
    "serve": "SERVER=true pnpm build:w",
    "test:e2e:cucumber": "NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e -f json:tests/e2e/cucumber/report/cucumber_report.json",
+    "test:e2e:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 npx playwright test --config=tests/e2e-playwright/ --project=chromium",


we should provide project while running the test: pnpm test:e2e:playwright -- --project=chromium

Suggested change

"test:e2e:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 npx playwright test --config=tests/e2e-playwright/ --project=chromium",

"test:e2e:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 npx playwright test --config=tests/e2e-playwright/",

saw-jan · 2025-09-05T04:26:19Z

tests/e2e-playwright/helper/cleanup.ts

+import { api, environment, store } from '../../e2e/support'
+import { User, UserState } from '../../e2e/support/types'
+
+const cleanupPredefinedUser = async (userKey: string, user: User) => {


let's omit dealing with predefined users in this PR

saw-jan · 2025-09-05T04:27:11Z

tests/e2e-playwright/helper/setAccessAndRefreshToken.ts

+import { User } from '../../e2e/support/types'
+import { UsersEnvironment } from '../../e2e/support/environment'
+
+const storeKeycloakGroups = async (adminUser: User, usersEnvironment) => {


same as above, let's omit dealing with keycloak in this PR

saw-jan · 2025-09-05T04:28:40Z

tests/e2e-playwright/playwright.config.ts

+  testDir: 'spec',
+
+  // Run all tests in parallel.
+  fullyParallel: true,


we cannot run tests in parallel

Suggested change

fullyParallel: true,

fullyParallel: false,

saw-jan · 2025-09-05T04:29:10Z

tests/e2e-playwright/playwright.config.ts

+ */
+export default defineConfig({
+  // Look for test files in the "tests" directory, relative to this configuration file.
+  testDir: 'spec',


Suggested change

testDir: 'spec',

testDir: 'specs',

saw-jan · 2025-09-05T04:54:34Z

tests/e2e-playwright/steps/api.ts

+  }
+}
+
+export async function createFolderInPersonalSpaceUsingAPI(


it's better to follow same naming for all the step methods

Suggested change

export async function createFolderInPersonalSpaceUsingAPI(

export async function userHasCreatedFolder(

saw-jan · 2025-09-05T04:55:31Z

tests/e2e-playwright/steps/api.ts

+  await api.dav.createFolderInsidePersonalSpace({ user, folder: folderName })
+}
+
+export async function shareResourceUsingAPI(


Suggested change

export async function shareResourceUsingAPI(

export async function userHasSharedResource(

Ashim-Stha self-assigned this Aug 20, 2025

Ashim-Stha added the QA:team label Aug 20, 2025

Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 14 times, most recently from 1facfa0 to 9b2c634 Compare August 25, 2025 10:46

Ashim-Stha marked this pull request as ready for review August 25, 2025 10:56

Ashim-Stha requested review from anon-pradip, saw-jan, prashant-gurung899, Salipa-Gurung, nabim777, PrajwolAmatya and nirajacharya2 August 25, 2025 10:57

Ashim-Stha changed the title ~~[tests-only][full-ci] Replace cucumber with playwright~~ [POC][tests-only] e2e tests with Playwright only Aug 25, 2025

nabim777 reviewed Aug 25, 2025

View reviewed changes

playwright.config.ts Outdated Show resolved Hide resolved

Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch from 9b2c634 to c242bfc Compare August 25, 2025 11:43

Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 2 times, most recently from 035965f to 69b0fc1 Compare August 29, 2025 11:25

saw-jan reviewed Sep 1, 2025

View reviewed changes

tests/e2e-playwright/helper/api.ts Outdated Show resolved Hide resolved

tests/e2e-playwright/helper/api.ts Outdated Show resolved Hide resolved

tests/e2e-playwright/helper/setAccessAndRefreshToken.ts Outdated Show resolved Hide resolved

saw-jan reviewed Sep 1, 2025

View reviewed changes

Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 5 times, most recently from aac2740 to 7a129ca Compare September 1, 2025 06:56

saw-jan reviewed Sep 1, 2025

View reviewed changes

tests/e2e/run-e2e.sh Outdated Show resolved Hide resolved

Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 13 times, most recently from b702b0c to be31630 Compare September 2, 2025 05:41

test: replace cucumber with playwright for internalLink.feature

aaea273

Signed-off-by: Ashim Shrestha <[email protected]>

Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch from be31630 to aaea273 Compare September 2, 2025 05:43

Ashim-Stha requested review from nirajacharya2 and saw-jan September 2, 2025 06:12

saw-jan reviewed Sep 5, 2025

View reviewed changes

	steps += tikaService() + \
	ocisService()
	steps += ocisService()

	"test:e2e:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 npx playwright test --config=tests/e2e-playwright/ --project=chromium",
	"test:e2e:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 npx playwright test --config=tests/e2e-playwright/",

	export async function createFolderInPersonalSpaceUsingAPI(
	export async function userHasCreatedFolder(

	export async function shareResourceUsingAPI(
	export async function userHasSharedResource(

[POC][tests-only] e2e tests with Playwright only #12941

Are you sure you want to change the base?

[POC][tests-only] e2e tests with Playwright only #12941

Uh oh!

Conversation

Ashim-Stha commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Run test

Uh oh!

CLAassistant commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saw-jan commented Aug 25, 2025

Uh oh!

Ashim-Stha commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 2, 2025

Quality Gate passed

Uh oh!

Ashim-Stha commented Sep 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ashim-Stha commented Aug 20, 2025 •

edited

Loading

CLAassistant commented Aug 20, 2025 •

edited

Loading