Skip to content

fix(ast/estree): Fix TSMethodSignature #10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Mar 25, 2025

Adds and skips fields to the Estree serialiser for the TSMethodSignature node.

Part of our broader work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705

Copy link
Contributor

graphite-app bot commented Mar 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-ast Area - AST label Mar 25, 2025
@therewillbecode therewillbecode changed the title fix(ast/estree): Fix TSMethodSignature fix(ast/estree): Fix TSMethodSignature Mar 25, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Mar 25, 2025
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Instrumentation Performance Report

Merging #10032 will not alter performance

Comparing therewillbecode:fix/TSMethodSignature-node (0030ef6) with main (1a0bd7c)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the fix/TSMethodSignature-node branch from ab19daa to 0030ef6 Compare March 25, 2025 12:01
@overlookmotel overlookmotel merged commit 8408606 into oxc-project:main Mar 25, 2025
25 checks passed
@therewillbecode therewillbecode deleted the fix/TSMethodSignature-node branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants