Skip to content

fix(ast/estree): Fix AccessorProperty node #10067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

therewillbecode
Copy link
Contributor

Align our AST's ESTree output with that of TS-ESLint's for theAccessorProperty node. Relates to #9705

Add optional, override, readonly, and declare fields to AccessorProperty when serializing to TS estree.

Copy link
Contributor

graphite-app bot commented Mar 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 26, 2025
Copy link

codspeed-hq bot commented Mar 26, 2025

CodSpeed Instrumentation Performance Report

Merging #10067 will degrade performances by 3.57%

Comparing therewillbecode:fix/accessor-property (761168d) with main (bf90072)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.57%
formatter[typescript.js] 7.6 ms 7.2 ms +5.57%

@therewillbecode therewillbecode force-pushed the fix/accessor-property branch from 9244fd4 to 9f6da65 Compare April 2, 2025 07:33
@overlookmotel overlookmotel force-pushed the fix/accessor-property branch from 9f6da65 to 761168d Compare April 2, 2025 11:31
@overlookmotel overlookmotel merged commit 498b479 into oxc-project:main Apr 2, 2025
25 checks passed
@therewillbecode therewillbecode deleted the fix/accessor-property branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants