Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/module_runner): handle re-export as deps #9696

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 12, 2025

There wasn't a test case for this on Vite, but missing re-export deps is spotted as a test case on Vitest vitest-dev/vitest#7646.

I'll add a test case on Vite vitejs/rolldown-vite#85 and the same one is added here.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Mar 12, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa changed the title fix(transformer/module_runner): fix deps of re-export fix(transformer/module_runner): handle re-export as deps Mar 12, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review March 12, 2025 03:53
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #9696 will not alter performance

Comparing 03-12-fix_transformer_module_runner_fix_deps_of_re-export (f9580d8) with main (ab594f1)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel removed their request for review March 12, 2025 06:47
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Copy link
Member

Dunqing commented Mar 12, 2025

Merge activity

  • Mar 12, 3:57 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 3:57 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 12, 4:02 AM EDT: A user merged this pull request with the Graphite merge queue.

There wasn't a test case for this on Vite, but missing re-export deps is spotted as a test case on Vitest vitest-dev/vitest#7646.

I'll add a test case on Vite vitejs/rolldown-vite#85 and the same one is added here.
@graphite-app graphite-app bot force-pushed the 03-12-fix_transformer_module_runner_fix_deps_of_re-export branch from 1c00780 to f9580d8 Compare March 12, 2025 07:57
@graphite-app graphite-app bot merged commit f9580d8 into main Mar 12, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
@graphite-app graphite-app bot deleted the 03-12-fix_transformer_module_runner_fix_deps_of_re-export branch March 12, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants