Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(linter): improve unicorn/filename-case #9762

Merged
merged 1 commit into from
Mar 13, 2025
Merged

refactor(linter): improve unicorn/filename-case #9762

merged 1 commit into from
Mar 13, 2025

Conversation

shulaoda
Copy link
Member

Related to #6050

  • Improve the documentation
  • Better code style

@shulaoda shulaoda requested review from camchenry and camc314 March 13, 2025 19:23
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@shulaoda shulaoda requested a review from Sysix March 13, 2025 19:23
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 13, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9762 will not alter performance

Comparing refactor/improve-unicorn-filename-case (9df5565) with main (b0b1f18)

Summary

✅ 33 untouched benchmarks

Sysix
Sysix approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see more options in the docs, but we do not implement them.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/filename-case.md

Should we move the rule?

@shulaoda
Copy link
Member Author

I see more options in the docs, but we do not implement them. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/filename-case.md

Should we move the rule?

Yes, the ignore option wasn't implemented initially, and the multipleFileExtensions option was added later. We should align with the corresponding plugin rules functionality, but this isn't part of the current PR.

We can improve it later when we have time, or would you be interested in working on it?

@Sysix
Copy link
Collaborator

Sysix commented Mar 13, 2025 •
edited
Loading

We can improve it later when we have time, or would you be interested in working on it?

Created Issue for this #9765

@shulaoda shulaoda added the 0-merge Merge with Graphite Merge Queue label Mar 13, 2025
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Mar 13, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 13, 5:06 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 13, 5:06 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 13, 5:12 PM EDT: A user merged this pull request with the Graphite merge queue.

@shulaoda
refactor(linter): improve unicorn/filename-case (#9762)
9df5565 
Related to #6050

- Improve the documentation
- Better code style
@graphite-app graphite-app bot force-pushed the refactor/improve-unicorn-filename-case branch from 3cfe571 to 9df5565 Compare March 13, 2025 21:07
@graphite-app graphite-app bot merged commit 9df5565 into main Mar 13, 2025
26 checks passed
@graphite-app graphite-app bot deleted the refactor/improve-unicorn-filename-case branch March 13, 2025 21:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 13, 2025
@oxc-bot oxc-bot mentioned this pull request Mar 16, 2025
Merged
Boshen added a commit that referenced this pull request Mar 16, 2025
@oxc-bot @Boshen
release(oxlint): v0.16.0 (#9800)
fef680a 
## [0.16.0] - 2025-03-16

- 225e266 linter: [**BREAKING**] Enable `--experimental-nested-config`
by default and add `--disable-nested-config` option (#9760) (camchenry)

### Features

- 27d6e9b editor: Only watch .oxlintrc.json or user supplied config
paths (#9731) (Nicholas Rayburn)
- 8dd6809 linter: Add `eslint/no-lonely-if` (#9660) (therewillbecode)
- c22276e oxc_linter: Sort rules by plugin and rule name when outputting
resolved config as a JSON string (#9799) (Nicholas Rayburn)

### Bug Fixes

- 22f18ac linter: Improve `jsx-a11y/anchor-ambiguous-text` diagnostic
message (#9789) (1zumii)
- 6c11740 linter: False positive in `unicorn/catch-error-name` (#9763)
(shulaoda)

### Documentation

- ea6b6d9 linter: Improve docs for `eslint-valid-typeof` (#9797)
(therewillbecode)
- 2c48fba linter: Fix typo in `oxc/bad-min-max-func` (#9791) (Flo)
- 210b876 linter: Improve `eslint-no-async-promise-executor` (#9778)
(therewillbecode)
- f8628bc linter: Improve `eslint-no-class-assign` (#9779)
(therewillbecode)
- faca7a8 linter: Improve `eslint-no-self-assign` (#9768)
(therewillbecode)

### Refactor

- 227d203 linter: Improve `typescript-no-unnecessary-type-constraint`
(#9798) (therewillbecode)
- 05fe2cd linter: Use `is_lexical` when checking for lexical decl
(#9781) (camc314)
- fcdd810 linter: Remove if let nesting from `unicorn-no-date-clone`
(#9767) (therewillbecode)
- 5a9e1b9 linter: Improve `typescript-no-misused-new` (#9766)
(therewillbecode)
- 9df5565 linter: Improve `unicorn/filename-case` (#9762) (shulaoda)
- b0b1f18 linter: Remove if let nesting from
`nextjs-no-async-client-component` (#9764) (therewillbecode)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sysix Sysix Sysix approved these changes

@camchenry camchenry Awaiting requested review from camchenry

@camc314 camc314 Awaiting requested review from camc314

Assignees
No one assigned
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @Sysix