-
-
Notifications
You must be signed in to change notification settings - Fork 20
feat(rules): Implement strict_boolean_expressions
#222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(rules): Implement strict_boolean_expressions
#222
Conversation
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
@nnnnoel feel free to just patch the typescript-go submodule rather than having to wait for typescript-go changes |
@camc314 I applied patch and added test cases for implemented rule |
FYI: tsgolint/shim/checker/extra-shim.json Lines 35 to 41 in 42296f6
Lines 939 to 959 in 42296f6
|
@auvred Thanks, I changed to consistent way to access private struct |
I tried some test cases from typescript-eslint and they report errors when they shouldn't? How did you port the test cases across?
|
Oh, I just requested to Claude code port file to golang, looks not fine. |
bebb1af
to
0d1245c
Compare
Closes #195