Rpc & log fixes #1862
Closed
Rpc & log fixes #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `get_accrued_rewards`: properly format ETH addresses
- `bls_exit_liquidation_list`: refactor to use existing serialization
for service node info instead of trying to shoehorn and edit the
binary serialization into acceptable output. This fixes numerous
inconsistencies between the info returned here, and the info returned
by other snode-returning endpoints (such as `get_service_nodes`):
- properly format ETH addresses
- fix "ethereum_beneficiary" -> "beneficiary" in contributors
- drop irrelevant/meaningless "reserved" from contributors
- remove externally meaningless "version" fields
- provide a swarm value readable everywhere, because larger integer
swarm ids are not parsable by many json engines.
- Correct inconsistent "bls_public_key", which should be "pubkey_bls"
- Don't include "total_reserved" and "reserved" fields.
- Add missing operator_fee
- Add missing "last_decomm_reasons" containing interpreted decomm
information rather than only raw bitfield values.
- `bls_exit_liquidation_list`: allow a "fields" input that works like
the (oxen 11) get_service_nodes "fields" array to be able to only
fetch selective data.
- SN info serialization common code: don't include useless empty
"locked_contributions" list for eth contributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing changes for 11.4.0, I found a log statement bug and some inconsistencies in RPC commands:
get_accrued_rewards: properly format ETH addressesbls_exit_liquidation_list: refactored it to use existing SN info serialization code, which fixes a bunch of inconsistencies and issues (see commit message). Also made it take a "fields" parameter which is already handled by the existing generic SN info code and so nearly free to implement.