Remove fast mode options from website build variant #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to keep the option for Play services in the website APK, at least until we develop a more reliable option for delivering notifications when Play services aren't available. One idea was a persistent foreground service which polls/subscribes for notifications for new messages, which i think can be achieved by displaying a persistent notification. |
3 tasks
|
This PR doesn't remove play services from So the UI gave you options that didn't do anything. |
|
Oh in that case we should actually add play store functionality back into the website APK's imo, not sure why it was removed in the first place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems our
websitebuild variant already avoids cloud messaging.This PR skips the activity for choosing to use it or not, and the preference that does the same thing. This option would have no effect anyway.
This is a good step towards a play-services-free build on Fdroid, as these screens would be concerning to privacy-centric users, and misinformation to others who expected that they would benefit from fast mode.
https://github.com/oxen-io/session-android-temp/issues/56