oxlog: Glob match zone names #8008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfchandler
force-pushed
the
wc/oxlog-glob-zones
branch
from
21d7e93 to
a127df5
Compare
wfchandler
changed the title
wfchandler
force-pushed
the
wc/oxlog-glob-zones
branch
2 times, most recently
from
c630c02 to
68c4778
Compare
`oxlog logs` currently requires a precise match for the zone name. This is inconvenient when attempting to search across multiple zones with similar names. For example, when searching all Crucible downstairs, or using Pilot to query Nexus logs on multiple sleds. Use the `glob` crate to take a pattern to match against the zone name for the `services` and `logs` subcommands, potentially allowing multiple zones to be returned. If more than one zone is matched, then the logs and services are sorted separately. Zones with a large number of archived logs may take an extended period to walk and sort, and when matching against multiple zones this becomes uncomfortably slow. To claw back some performance, use Rayon to find files and sort in parallel. We limit the size of its thread pool to a maximum of eight threads to avoid soaking up all available threads on a sled. On smaller machines we fall back to the number of logical threads. Example usage: $ oxlog services 'oxz_crucible_[!p]*' # All non-pantry Crucible zones $ oxlog logs 'oxz_nexus_*' --current # The nexus zone
wfchandler
force-pushed
the
wc/oxlog-glob-zones
branch
from
68c4778 to
3c07c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oxlog logscurrently requires a precise match for the zone name. Thisis inconvenient when attempting to search across multiple zones with
similar names. For example, when searching all Crucible downstairs, or
using Pilot to query Nexus logs on multiple sleds.
Use the
globcrate to take a pattern to match against the zone namefor the
servicesandlogssubcommands, potentially allowing multiplezones to be returned. If more than one zone is matched, then the logs
and services will be sorted globally.
Zones with a large number of archived logs may take a second or more to
sort, and when matching against multiple zones this becomes
uncomfortably slow. To claw back some performance, use Rayon to sort in
parallel. We limit the size of its thread pool to a maximum of 12
threads to avoid soaking up all available threads on a sled. On smaller
machines we fall back to the number of logical threads.
Example usage: