misc: updates to run simulated omicron in container #8996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support building omicron in environments that don't include sudo, like some docker images, add an OMIT_SUDO flag to ./tools/install_builder_prerequisites.sh.
jmcarp
force-pushed
the
jmcarp/prereqs-omit-sudo
branch
from
7316f71 to
0e0edce
Compare
davepacheco
reviewed
Sep 4, 2025
nexus/examples/config.toml
Outdated
| @@ -39,7 +39,7 @@ external_dns_servers = ["1.1.1.1", "9.9.9.9"] | |||
|
|
|||
| [deployment.dropshot_external] | |||
| # IP Address and TCP port on which to listen for the external API | |||
| bind_address = "127.0.0.1:12220" | |||
| bind_address = "0.0.0.0:12220" | |||
There was a problem hiding this comment.
This feels kind of dangerous because we might be exposing this service on any IP on the developer's network, right?
Can your use case provide its own config file for this instead? Or maybe make this an argument to omicron-dev?
There was a problem hiding this comment.
Updated to add a flag to override the config file path for omicron-dev.
jmcarp
force-pushed
the
jmcarp/prereqs-omit-sudo
branch
2 times, most recently
from
5763290 to
ac1daff
Compare
Add a --nexus-config flag to omicron-dev to allow custom configuration for local testing.
jmcarp
force-pushed
the
jmcarp/prereqs-omit-sudo
branch
from
ac1daff to
d667c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oxidecomputer/terraform-provider-oxide#497, we're proposing to run the acceptance tests for the terraform provider against simulated omicron. We're running omicron in a docker container for portability. This PR contains a few small script changes to omicron to make it work in a container: