Fix --debug flag
#878
Merged
Fix --debug flag
#878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `--debug` flag does not actually enable debug logging as intended. We initialize `env_logger` immediately in `main`, then attempt to change the log filtering level in `NewCli::run` if the `--debug` flag is passed. This does not work, as `env_logger::builder` needs its `init` method to be called to change the global logger. This is not an option, as we've already called `env_logger::init`. The internet suggests[0] that using `log::set_max_level` lets us change the level independently of logger initialization, but this did not work when I tried it out. Move logger initialization into `NewCli::run` so that we know the desired log level ahead of calling `init`. This means that items logged before we initialize the logger will be lost, but in practice we're not missing anything. [0] rust-cli/env_logger#228 (comment)
ahl
reviewed
Oct 14, 2024
cli/tests/test_auth.rs
Outdated
Comment on lines
580
to
581
| .env("OXIDE_HOST", server.url("")) | ||
| .env("OXIDE_TOKEN", "oxide-token-bad") |
There was a problem hiding this comment.
do we need this for auth login?
There was a problem hiding this comment.
Whoops, good catch. Was trying this test with auth login and auth status and forgot to remove them.
Fixed in 3c306c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
--debugflag does not actually enable debug logging asintended. We initialize
env_loggerimmediately inmain, then attemptto change the log filtering level in
NewCli::runif the--debugflagis passed. This does not work, as
env_logger::builderneeds itsinitmethod to be called to change the global logger. This is not an option,
as we've already called
env_logger::init. The internet suggeststhat using
log::set_max_levellets us change the level independentlyof logger initialization, but this did not work when I tried it out.
Move logger initialization into
NewCli::runso that we know thedesired log level ahead of calling
init. This means that items loggedbefore we initialize the logger will be lost, but in practice we're not
missing anything.