Append -gnu to RUBY_TARGET for GNU Linux builds #511
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rake-compiler-dock images now make a distinction between GNU and musl builds. Add a `-gnu` extension to `RUBY_TARGET` to make it possible to run: ``` rb-sys-dock --platform x86_64-linux-gnu --directory . --build ``` Closes oxidize-rb#510
|
note to self: check build result -> https://github.com/oxidize-rb/rb-sys/actions/runs/13057340828 |
|
Oh, sorry, the tests aren't passing because the image is producing Perhaps we have to make this configurable then. |
stanhu
added a commit
to stanhu/rb-sys
that referenced
this pull request
Jan 30, 2025
…)" This reverts commit 798fad1.
ianks
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Revert "Append -gnu to RUBY_TARGET for GNU Linux builds (#511)" This reverts commit 798fad1. * Make it possible to override RUBY_TARGET Previously if you attempt to run `rb-sys-dock --platform x86_64-linux-gnu` the `RUBY_TARGET` was hard-coded to `x86_64-linux`. Now this can be overriden by the `rb-sys-dock` so that the `--platform` argument can work with `x86_64-linux` or `x86_64-linux-gnu`.
stanhu
added a commit
to stanhu/rb-sys
that referenced
this pull request
Jan 30, 2025
…)" This reverts commit 798fad1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake-compiler-dock images now make a distinction between GNU and musl builds. Add a
-gnuextension toRUBY_TARGETto make it possible to run:Closes #510