Move the assembler to P4C.

[fruffy]

Fixes #54.

[jafingerhut]

If I do a diff on these directories in the latest versions of p4c and open-p4studio repos (before this PR's changes), I see this:

$ diff -cr open-p4studio/pkgsrc/p4-compilers/bf-asm p4c/backends/tofino/bf-asm | grep '^Only in '
Only in open-p4studio/pkgsrc/p4-compilers/bf-asm/cmake: Abseil.cmake
Only in p4c/backends/tofino/bf-asm/cmake: config.h.cmake
Only in open-p4studio/pkgsrc/p4-compilers/bf-asm/cmake: config.h.in
Only in open-p4studio/pkgsrc/p4-compilers/bf-asm: CPPLINT.cfg
Only in open-p4studio/pkgsrc/p4-compilers/bf-asm: test

is it intentional not to copy over the pkgsrc/p4-compilers/bf-asm/test directory, and all of the many tests it contains? I understand they are still in the git commit history here, but would it perhaps be better if they were also added to the p4c repo, for possible future use?

[fruffy]

is it intentional not to copy over the pkgsrc/p4-compilers/bf-asm/test directory, and all of the many tests it contains?

Yes, the context is this comment: p4lang/p4c#5121 (comment)

[jafingerhut]

is it intentional not to copy over the pkgsrc/p4-compilers/bf-asm/test directory, and all of the many tests it contains?

Yes, the context is this comment: p4lang/p4c#5121 (comment)

Makes sense. I did see that earlier, but thank for the reminder.

[jafingerhut]

LGTM

[fruffy]

Does it build on your local setup? I remember there were some problems in #65.

[jafingerhut]

I am away from home and my x86_64 systems until evening of Mar 19, and don't have remote login set up for them. I can try it then.

[jafingerhut]

I created a freshly installed Ubuntu 22.04 desktop Linux VM for x86_64, and ran the commands listed in the file cmds.txt that is part of the attached zip file, but it gave errors during building the code during the p4studio profile appply ... command. The zip file contains the full output of that command, and the contents of the log file created in the logs directory. The cmds.txt file shows exactly which commit SHAs of the open-p4studio and p4c repo were in use.

logs.zip

[fruffy]

Could you try the new refpoint? Nevermind, there are quite a few more issues...back to the drawing board.

[jafingerhut]

@fruffy Ready for another local test run on this?

[fruffy]

Yes, let's give it a try.

…

On March 24, 2025 1:48:38 PM GMT+01:00, Andy Fingerhut ***@***.***> wrote: jafingerhut left a comment (p4lang/open-p4studio#70) @fruffy Ready for another local test run on this? -- Reply to this email directly or view it on GitHub: #70 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[jafingerhut]

Attached are build logs with errors from my attempt to build this PR's version of open-p4studio on 2024-Mar-24 on a freshly installed Ubuntu 22.04 x86_64 VM running in VirtualBox. I have not attempted to analyze the errors myself.
logs.zip

[jafingerhut]

There is no need to explain if it is complex, but are there any briefly-described known reasons why CI on Ubuntu 22.04 gives clean build and test, but on a freshly installed Ubuntu 22.04 VM I get build errors? I am guessing there must be something different about the software installed on my VM vs. the CI version, but don't have good guesses what those are.

[fruffy]

The error you are encountering is likely related to the preprocessor (and GNU extension support?). I am not sure what could be different. If I disable this line: https://github.com/p4lang/p4c/blob/main/backends/tofino/bf-asm/CMakeLists.txt#L249

I can reproduce it.. but not sure it doesn't work for you.