-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExactMap and TernaryMap extern definitions to pna.p4 #52
Open
jfingerh
wants to merge
11
commits into
p4lang:main
Choose a base branch
from
jfingerh:add-ExactMap-TernaryMap-externs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
41074e2
Add ExactMap and TernaryMap extern definitions to pna.p4
jafingerhut 921ed26
Update proposed externs to use new `list` type in P4
jafingerhut 8da0069
Add comments describing control plane API of ExactMap and TernaryMap …
jafingerhut b35f719
Merge branch 'main' into add-ExactMap-TernaryMap-externs
jafingerhut 1ee934a
Remove pre-control from example program
jafingerhut 764e945
Add parameters of action 'lookup' to the four example instantiations
jafingerhut 6a68668
Fix copy and paste bug
jafingerhut 5eb00c8
Clarify in pna.p4 that const_entries for a TernaryMap is earliest-ent…
jafingerhut 7ea8e47
Correct some erroneous comments in pna-example-exactmap-ternarymap.p4
jafingerhut 235713e
Merge branch 'main' into add-ExactMap-TernaryMap-externs
jafingerhut 7759270
Add a note about control plane API generation for ExactMap and Ternar…
jafingerhut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add a note about control plane API generation for ExactMap and Ternar…
…yMap
commit 7759270a3a10b783652665ca209c3e7310656433
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamescchoi See the paragraph comment I just added earlier today (2022-Nov-29) following up on a question in a meeting we had earlier today.