Skip to content

minor efficiency improvements and code cleanup#501

Open
svdrecbd wants to merge 2 commits intopachterlab:masterfrom
svdrecbd:perf-optimizations
Open

minor efficiency improvements and code cleanup#501
svdrecbd wants to merge 2 commits intopachterlab:masterfrom
svdrecbd:perf-optimizations

Conversation

@svdrecbd
Copy link

Changes:

  • MinCollector: Updated the sort comparator to use block-identity checks instead of deep set comparisons.
  • KmerIndex: Replaced the shading map lookup with a vector-based approach (using lazy allocation to avoid overhead in standard runs).
  • ProcessReads: Removed a redundant linear search in the strand-specific mapping logic.
  • Indexing: Minor refactor of amino acid translation to reduce heap allocations.
  • Bifrost: Fixed a small member-access compilation error in the submodule.

Bug Fixes:

Fixed a compilation error in ext/bifrost submodule (DataStorage.tcc) where an incorrect member variable was accessed, preventing successful builds on some architectures.

Verification:

All changes were verified to produce bit-exact output identical to the current master branch. While end-to-end runtime improvements are modest on standard datasets where I/O dominates, these changes improve the algorithmic efficiency of the targeted functions.

- MinCollector: optimize sort comparator using block-ID check

- KmerIndex: replace unordered_map with vector for shade lookups

- bifrost: fix compilation error in DataStorage.tcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant