Skip to content

feat: initial test template docs and major reorganisation #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: initial test template docs and major reorganisation #336

wants to merge 1 commit into from
+857 −198

Conversation

mefellows
Copy link
Contributor

@mefellows mefellows commented Feb 11, 2025 •
edited by jira bot
Loading

@netlify Netlify
Copy link

netlify bot commented Feb 11, 2025 •
edited
Loading

✅ Deploy Preview for docs-pactflow-preview ready!

Name Link
🔨 Latest commit a4ab343
🔍 Latest deploy log https://app.netlify.com/sites/docs-pactflow-preview/deploys/67fe53b56daf3e0008204013
😎 Deploy Preview https://deploy-preview-336--docs-pactflow-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JP-Ellis
JP-Ellis approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@JP-Ellis JP-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's been a few updates since the first round of docs, and you may have seen I've created a few PRs on the Accord codebase too to try and ensure alignment.

@mefellows mefellows force-pushed the feat/PACT-1888-ai-test-template-docs branch 6 times, most recently from bcac915 to e97ae61 Compare April 7, 2025 06:46
@mefellows mefellows marked this pull request as ready for review April 7, 2025 06:47
JP-Ellis
JP-Ellis reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@JP-Ellis JP-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first read over. Might do a second one tomorrow morning 👍

@mefellows mefellows requested a review from YOU54F April 7, 2025 08:19
@mefellows mefellows force-pushed the feat/PACT-1888-ai-test-template-docs branch 4 times, most recently from 57269f9 to 95a34d7 Compare April 9, 2025 07:16
MateuszKupczakSB
MateuszKupczakSB requested changes Apr 10, 2025
View reviewed changes
Copy link

@MateuszKupczakSB MateuszKupczakSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to improve.

MateuszKupczakSB
MateuszKupczakSB requested changes Apr 11, 2025
View reviewed changes
Copy link

@MateuszKupczakSB MateuszKupczakSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to improve.

@mefellows mefellows force-pushed the feat/PACT-1888-ai-test-template-docs branch from 95a34d7 to 5d8af65 Compare April 15, 2025 05:22
@mefellows
Copy link
Contributor Author

Thanks Mateusz - updated!

@mefellows mefellows force-pushed the feat/PACT-1888-ai-test-template-docs branch from 5d8af65 to 41822e3 Compare April 15, 2025 05:26
MateuszKupczakSB
MateuszKupczakSB approved these changes Apr 15, 2025
View reviewed changes
Copy link

@MateuszKupczakSB MateuszKupczakSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mefellows mefellows force-pushed the feat/PACT-1888-ai-test-template-docs branch from 41822e3 to f6f609f Compare April 15, 2025 12:26
@mefellows mefellows force-pushed the feat/PACT-1888-ai-test-template-docs branch from f6f609f to a4ab343 Compare April 15, 2025 12:40
@YOU54F YOU54F self-requested a review April 15, 2025 12:45
YOU54F
YOU54F approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, really like the rework.

Should we also add a column under integrations that points to this AI section?

I only knew it was under features because of the PR file tree. The main docs page is just getting started, and doesn't link to any of the feature pages.

Maybe highlighting the features under the learn about contract testing, or learn about PactFlows features to guide users to the features tabs.

There isn't a high level feature page, just a side bar, so we can't say, ready to start, check out all of PactFlow's features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F YOU54F approved these changes

@MateuszKupczakSB MateuszKupczakSB MateuszKupczakSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mefellows @JP-Ellis @YOU54F @MateuszKupczakSB