Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPLT-784] Request App feedback to user #6617

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jan 20, 2025

Note

This PR depends on pagopa/io-services-metadata#928

Short description

This PR implements the new feature to let the user give a feedback on pre-defined survey during specific flows

List of changes proposed in this pull request

  • Handle the new remote config for app feedback
  • Implements the hook to handle the logic of alert presentation
  • Handle the store and persist of last given feedback log
  • Changes the previously implemented callback trigger to ask for review only on device app store

How to test

Check the specific playground under Settings > Developer mode > Playgrounds > App feedback playground
Use pagopa/io-dev-api-server#464 to test

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-07.at.12.36.17.mp4

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 59.03614% with 34 lines in your changes missing coverage. Please review.

Project coverage is 50.02%. Comparing base (df85e81) to head (379ce2c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/features/appReviews/hooks/useAppReviewRequest.ts 47.36% 10 Missing ⚠️
...eens/profile/playgrounds/AppFeedbackPlayground.tsx 9.09% 10 Missing ⚠️
ts/features/appReviews/store/reducers/index.ts 60.00% 6 Missing ⚠️
ts/store/reducers/backendStatus/remoteConfig.ts 66.66% 4 Missing ⚠️
ts/screens/profile/DeveloperModeSection.tsx 0.00% 3 Missing ⚠️
ts/features/appReviews/store/selectors/index.ts 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
+ Coverage   50.00%   50.02%   +0.01%     
==========================================
  Files        1557     1563       +6     
  Lines       32445    32526      +81     
  Branches     7345     7312      -33     
==========================================
+ Hits        16223    16270      +47     
- Misses      16171    16216      +45     
+ Partials       51       40      -11     
Files with missing lines Coverage Δ
ts/features/appReviews/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/appReviews/utils/date.ts 100.00% <100.00%> (ø)
ts/features/appReviews/utils/storeReview.ts 100.00% <ø> (ø)
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
...twallet/common/hooks/useItwPendingReviewRequest.ts 100.00% <100.00%> (ø)
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 85.50% <100.00%> (+0.10%) ⬆️
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/features/appReviews/store/selectors/index.ts 90.00% <90.00%> (ø)
ts/screens/profile/DeveloperModeSection.tsx 24.81% <0.00%> (-0.58%) ⬇️
... and 4 more

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df85e81...379ce2c. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@CrisTofani CrisTofani changed the title [IOPLT-784] Request App feedback to user feat: [IOPLT-784] Request App feedback to user Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legal-review-needed ⚖️ ⛔ this PR is under legal check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants