feat(IT Wallet): [SIW-1972] Remote presentation same device #6689

RiccardoMolinari95 · 2025-02-05T10:30:41Z

Short description

This PR introduces the ability to start the remote presentation flow through a deep link in a same-device scenario.

List of changes proposed in this pull request

Updated useItwLinkingOptions to include linking options for remote deep link
Added ItwRemoteRequestValidationScreen, which receives the payload and validates it. If the payload is invalid, an error screen, for deeplink, will be displayed (TODO). If valid, it sends the start event to the remote presentation machine
Modified decodeItwRemoteBarcode to validate that the URL starts with https://continua.io.pagopa.it/itw/auth, checks the content of the QR code against the ItwRemoteRequestPayload type, and finally sends the URL

How to test

Use the following link as a deep link and to generate a QR code:
https://continua.io.pagopa.it/itw/auth?client_id=abc123xy&request_uri=https%3A%2F%2Fexample.com%2Fcallback&state=hyqizm592

github-actions · 2025-02-05T10:30:57Z

PR Title Validation for conventional commit type

✅ All good! PR title follows the conventional commit type.

github-actions · 2025-02-05T10:31:07Z

Jira Pull Request Link

This Pull Request refers to Jira issues:

SIW-1972

mastro993 · 2025-02-14T11:55:08Z

ts/features/barcode/types/__tests__/decoders.test.ts

-
-  describe("test ITW_REMOTE barcode type", () => {
-    it("should return O.some on valid QRCode content", () => {
-      const value =
-        "https://continua.io.pagopa.it/itw/auth?client_id=abc123xy&request_uri=https%3A%2F%2Fexample.com%2Fcallback&state=hyqizm592";
-
-      const output = decodeIOBarcode(value);
-
-      expect(output).toStrictEqual(
-        O.some({
-          type: "ITW_REMOTE",
-          itwRemoteRequestPayload: {
-            clientId: "abc123xy",
-            requestUri: "https://example.com/callback",
-            state: "hyqizm592",
-            requestUriMethod: "GET"
-          }
-        })
-      );
-    });
-
-    it("should decode request_uri_method if provided", () => {
-      const value =
-        "https://continua.io.pagopa.it/itw/auth?client_id=abc123xy&request_uri=https%3A%2F%2Fexample.com%2Fcallback&state=hyqizm592&request_uri_method=POST";
-
-      const output = decodeIOBarcode(value);
-
-      expect(output).toStrictEqual(
-        O.some({
-          type: "ITW_REMOTE",
-          itwRemoteRequestPayload: {
-            clientId: "abc123xy",
-            requestUri: "https://example.com/callback",
-            state: "hyqizm592",
-            requestUriMethod: "POST"
-          }
-        })
-      );
-    });
-
-    it("should return O.none if request_uri is missing", () => {
-      const value =
-        "https://continua.io.pagopa.it/itw/auth?client_id=abc123xy&state=hyqizm592";
-
-      const output = decodeIOBarcode(value);
-
-      expect(output).toStrictEqual(O.none);
-    });
-
-    it("should return O.none if client_id is missing", () => {
-      const value =
-        "https://continua.io.pagopa.it/itw/auth?request_uri=https%3A%2F%2Fexample.com%2Fcallback&state=hyqizm592";
-
-      const output = decodeIOBarcode(value);
-
-      expect(output).toStrictEqual(O.none);
-    });
-
-    it("should return O.none if both client_id and request_uri are missing", () => {
-      const value =
-        "https://continua.io.pagopa.it/itw/auth?state=hyqizm592&request_uri_method=POST";
-
-      const output = decodeIOBarcode(value);
-
-      expect(output).toStrictEqual(O.none);
-    });
-  });


Don't we need tests for barcode decoding?

Absolutely. I forgot to reintroduce this file. Thanks

mastro993 · 2025-02-14T11:58:14Z

ts/features/barcode/screens/BarcodeScanScreen.tsx

-        navigation.navigate(ITW_REMOTE_ROUTES.MAIN, {
-          screen: ITW_REMOTE_ROUTES.CLAIMS_DISCLOSURE,
-          params: {
-            itwRemoteRequestPayload: barcode.itwRemoteRequestPayload
-          }
-        });


Since we are already extracting data from the url, we could pass the payload direclty to the screen. What do you think?

mastro993 · 2025-02-14T12:06:51Z

ts/features/barcode/types/decoders.ts

+    O.chain(params =>
+      pipe(
+        ItwRemoteRequestPayload.decode({
+          client_id: params.get("client_id"),
+          request_uri: params.get("request_uri"),
+          state: params.get("state")
+        }),
+        E.fold(
+          () => O.none,
+          () => O.some({ type: "ITW_REMOTE", authUrl: data })


Can be simplified, also request_uri_method is missing.
I'd suggest to return the payload since we have already parsed it.

Suggested change

O.chain(params =>

pipe(

ItwRemoteRequestPayload.decode({

client_id: params.get("client_id"),

request_uri: params.get("request_uri"),

state: params.get("state")

}),

E.fold(

() => O.none,

() => O.some({ type: "ITW_REMOTE", authUrl: data })

O.chainEitherK(params =>

ItwRemoteRequestPayload.decode({

client_id: params.get("client_id"),

request_uri: params.get("request_uri"),

state: params.get("state"),

request_uri_method: params.get("request_uri_method")

})

),

O.map(payload => ({ type: "ITW_REMOTE", payload }))

I understand your point of view, and you are right; once we parse the payload, it would be better to use it directly. However, we decided to pass the URL for consistency with the deep link case.
This way, we can handle the payloads coming from both the QR code and the deep link differently when navigating to ItwRemoteRequestValidationScreen.

Yes, we agreed together about it, but:

by design, we need to show an error message whenever we have an invalid QR code

a double parse is not optimal and is more prone to errors.
For these reasons I think we should pass through a normal navigation

Check the corrections in edc51dd

mastro993 · 2025-02-14T12:08:31Z

ts/features/itwallet/presentation/remote/machine/actions.ts

@@ -32,6 +32,12 @@ export const createRemoteActionsImplementation = (
    });
  },

+  navigateToClaimsDisclosureScreen: () => {
+    navigation.navigate(ITW_REMOTE_ROUTES.MAIN, {


The previous screen is temporary, we can safely replace it.

Suggested change

navigation.navigate(ITW_REMOTE_ROUTES.MAIN, {

navigation.replace(ITW_REMOTE_ROUTES.MAIN, {

RiccardoMolinari95 and others added 14 commits January 31, 2025 15:11

feat: scan qr code for remote presentation

d73f30d

Merge branch 'master' into SIW-1960-scan-qr-code-remote-presentation

b2da4d3

chore: add missing locales

fc799a5

chore: updated regex for itw_remote barcode

624a3d8

Merge branch 'master' into SIW-1960-scan-qr-code-remote-presentation

786f4f3

fix: prettify

196a756

chore: improvement itw remote qr code decoding

f28f1c2

Merge branch 'master' into SIW-1960-scan-qr-code-remote-presentation

7a96824

chore: fix import

1728d91

refactor: change qrCodePayload in remoteRequestPayload

2452726

Merge branch 'master' into SIW-1960-scan-qr-code-remote-presentation

e76db18

Merge branch 'master' into SIW-1960-scan-qr-code-remote-presentation

3ffe18f

Merge branch 'master' into SIW-1960-scan-qr-code-remote-presentation

b2316b4

feat: remote presentation same device

b08c736

RiccardoMolinari95 added the IT Wallet label Feb 5, 2025

RiccardoMolinari95 self-assigned this Feb 5, 2025

RiccardoMolinari95 requested review from ChrisMattew, gispada, freddi301 and a team as code owners February 5, 2025 10:30

RiccardoMolinari95 temporarily deployed to dev February 5, 2025 10:39 — with GitHub Actions Inactive

RiccardoMolinari95 temporarily deployed to dev February 13, 2025 13:37 — with GitHub Actions Inactive

mastro993 reviewed Feb 14, 2025

View reviewed changes

chore: navigateToClaimsDisclosureScreen uses navigation replace

91ffd03

RiccardoMolinari95 temporarily deployed to dev February 14, 2025 14:03 — with GitHub Actions Inactive

chore: change decoder for itw remote

edc51dd

RiccardoMolinari95 temporarily deployed to dev February 14, 2025 15:05 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(IT Wallet): [SIW-1972] Remote presentation same device #6689

feat(IT Wallet): [SIW-1972] Remote presentation same device #6689

RiccardoMolinari95 commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025 •

edited

Loading

mastro993 Feb 14, 2025

RiccardoMolinari95 Feb 14, 2025

mastro993 Feb 14, 2025

mastro993 Feb 14, 2025

RiccardoMolinari95 Feb 14, 2025

mastro993 Feb 14, 2025

RiccardoMolinari95 Feb 14, 2025 •

edited

Loading

mastro993 Feb 14, 2025

	navigation.navigate(ITW_REMOTE_ROUTES.MAIN, {
	navigation.replace(ITW_REMOTE_ROUTES.MAIN, {

feat(IT Wallet): [SIW-1972] Remote presentation same device #6689

Are you sure you want to change the base?

feat(IT Wallet): [SIW-1972] Remote presentation same device #6689

Conversation

RiccardoMolinari95 commented Feb 5, 2025 • edited Loading

Short description

List of changes proposed in this pull request

How to test

github-actions bot commented Feb 5, 2025

PR Title Validation for conventional commit type

github-actions bot commented Feb 5, 2025 • edited Loading

Jira Pull Request Link

mastro993 Feb 14, 2025

Choose a reason for hiding this comment

RiccardoMolinari95 Feb 14, 2025

Choose a reason for hiding this comment

mastro993 Feb 14, 2025

Choose a reason for hiding this comment

mastro993 Feb 14, 2025

Choose a reason for hiding this comment

RiccardoMolinari95 Feb 14, 2025

Choose a reason for hiding this comment

mastro993 Feb 14, 2025

Choose a reason for hiding this comment

RiccardoMolinari95 Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

mastro993 Feb 14, 2025

Choose a reason for hiding this comment

RiccardoMolinari95 commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025 •

edited

Loading

RiccardoMolinari95 Feb 14, 2025 •

edited

Loading