Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PE-965] CGN Swipe back gesture to root stack navigator #6708

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Feb 12, 2025

Short description

This PR fixes the swipe-back gesture inside the CGN screens, causing incorrect navigation directly to the root navigator instead of the previous screen in the stack.

List of changes proposed in this pull request

  • Created a custom hook useDisableRootNavigatorGesture that disables the root navigator swipe back gesture when invoked.

Preview

Before After
before.MP4
after.mov

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.94%. Comparing base (6099525) to head (ba77743).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...bonus/cgn/hooks/useDisableRootNavigatorGesture.tsx 16.66% 5 Missing ⚠️
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6099525) and HEAD (ba77743). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (6099525) HEAD (ba77743)
10 6
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6708      +/-   ##
==========================================
- Coverage   50.04%   43.94%   -6.10%     
==========================================
  Files        1557     1418     -139     
  Lines       32446    30098    -2348     
  Branches     7345     6800     -545     
==========================================
- Hits        16236    13227    -3009     
- Misses      16158    16829     +671     
+ Partials       52       42      -10     
Files with missing lines Coverage Δ
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 25.00% <0.00%> (-1.32%) ⬇️
...bonus/cgn/hooks/useDisableRootNavigatorGesture.tsx 16.66% <16.66%> (ø)

... and 345 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6099525...ba77743. Read the comment docs.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think to add coverage for missing test in this development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants