-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [PE-965] CGN Swipe back gesture to root stack navigator #6708
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6708 +/- ##
==========================================
- Coverage 50.04% 43.94% -6.10%
==========================================
Files 1557 1418 -139
Lines 32446 30098 -2348
Branches 7345 6800 -545
==========================================
- Hits 16236 13227 -3009
- Misses 16158 16829 +671
+ Partials 52 42 -10
... and 345 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think to add coverage for missing test in this development?
Short description
This PR fixes the swipe-back gesture inside the CGN screens, causing incorrect navigation directly to the root navigator instead of the previous screen in the stack.
List of changes proposed in this pull request
useDisableRootNavigatorGesture
that disables the root navigator swipe back gesture when invoked.Preview
before.MP4
after.mov