chore: [IOPID-2663] Updated the banner copy on the IdP selection page #6717
+3
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
shadowsheep1
requested review from
thisisjp,
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
|
@mariateresaventura copy review needed 🙏 |
shadowsheep1
added
IO-A&I
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6717 +/- ##
==========================================
+ Coverage 45.73% 50.00% +4.27%
==========================================
Files 1551 1557 +6
Lines 32379 32442 +63
Branches 7332 7344 +12
==========================================
+ Hits 14809 16224 +1415
+ Misses 17534 16167 -1367
- Partials 36 51 +15
... and 143 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Updated the banner copy on the IdP selection page.
Note
Accessibility has not been tested because only the copy of the component has been changed, not its structure.
Details
List of changes proposed in this pull request
ts/screens/authentication/IdpSelectionScreen.tsx: Removed the import ofisFastLoginEnabledSelectorand its usage in theIdpSelectionScreencomponent. [1] [2]ts/screens/authentication/IdpSelectionScreen.tsx: Updated the banner content to use the newbannerDefaultInfolocalization key.How to test
Navigate to the IdP selection page and verify that the banner displays the updated copy.