Deploy full scale oauth functionality #97
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,68 +1,61 @@ | ||
| const Ebay = require('../src/index'); | ||
| const { clientId, clientSecret } = require('./credentials/index'); | ||
|
|
||
| let ebay = new Ebay({ | ||
| clientID: clientId, | ||
| clientSecret: clientSecret, | ||
| }); | ||
|
|
||
| // Getting access token and calling getItem method. | ||
| ebay.getApplicationToken() | ||
| .then((data) => { | ||
| ebay.setAppAccessToken(data); | ||
| ebay.getItemById('v1|202117468662|0').then((data) => { | ||
| console.log(data); | ||
| // Data is in format of JSON | ||
| // To check the format of Data, Go to this url (https://jsonblob.com/56cbea67-30b8-11e8-953c-5d1886dcf4a0) | ||
| }) | ||
| }); | ||
|
|
||
| // Reference ebay developer page https://developer.ebay.com/api-docs/buy/browse/resources/item/methods/getItemByLegacyId#_samples | ||
| // Getting access token and calling getItemByLegacyId method. | ||
| ebay.getApplicationToken() | ||
| .then((data) => { | ||
| ebay.setAppAccessToken(data); | ||
| ebay.getItemByLegacyId({ | ||
| legacyItemID: 2628001 // Get Item Details Using a Legacy ID | ||
| }).then((data) => { | ||
| console.log(data); | ||
| // Data is in format of JSON | ||
| // To check the format of Data, Go to this url (https://jsonblob.com/56cbea67-30b8-11e8-953c-5d1886dcf4a0) | ||
| }); | ||
| }); | ||
|
|
||
| // Get Item Details Using a Legacy ID and SKU | ||
| ebay.getApplicationToken() | ||
| .then((data) => { | ||
| ebay.setAppAccessToken(data); | ||
| ebay.getItemByLegacyId({ | ||
| legacyItemID: 110039490209, | ||
| legacyVariationSku: 'V-00031-WHM' | ||
| }).then((data) => { | ||
| console.log(data); | ||
| // Data is in format of JSON | ||
| // To check the format of Data, Go to this url (https://jsonblob.com/56cbea67-30b8-11e8-953c-5d1886dcf4a0) | ||
| }); | ||
| }); | ||
|
|
||
|
|
||
| // retrieves the details of the individual items in an item group | ||
| // reference https://developer.ebay.com/api-docs/buy/browse/resources/item/methods/getItemsByItemGroup#uri.item_group_id | ||
| ebay.getApplicationToken() | ||
| .then((data) => { | ||
| ebay.setAppAccessToken(data); | ||
| ebay.getItemByItemGroup('351825690866').then((data) => { | ||
| // Data is in format of JSON | ||
| // To check the format of Data, Go to this url (https://jsonblob.com/56cbea67-30b8-11e8-953c-5d1886dcf4a0) | ||
| console.log(data) | ||
| }, (error) => { | ||
| console.log(error); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,8 @@ ebay.findItemsByKeywords({ | |
| Condition: 3000, | ||
| SoldItemsOnly: false, | ||
| affiliate: { | ||
| networkID: 9, | ||
| trackingID: 1234567890 | ||
| } | ||
| }).then((data) => { | ||
| console.log(data); | ||
|
|
@@ -36,7 +36,7 @@ sale by category (using categoryId), by keywords (using keywords), or a combinat | |
| Keyword queries search the title and subtitle of the item; they do not search descriptions. */ | ||
| ebay.findCompletedItems({ | ||
| keywords: 'Garmin nuvi 1300 Automotive GPS Receiver', | ||
| categoryID: '156955', | ||
| sortOrder: 'PricePlusShippingLowest', //https://developer.ebay.com/devzone/finding/callref/extra/fndcmpltditms.rqst.srtordr.html | ||
| Condition: 3000, | ||
| SoldItemsOnly: true, | ||
|
|
@@ -50,7 +50,7 @@ ebay.findCompletedItems({ | |
| // // This call searches for items on eBay using specific eBay product values. | ||
| // https://developer.ebay.com/DevZone/finding/CallRef/findItemsByProduct.html#findItemsByProduct | ||
| ebay.findItemsByProduct({ | ||
| productID: 53039031, | ||
| entriesPerPage: 2 | ||
|
There was a problem hiding this comment. @TotallyNotChase I don't think you have to change variable names as part of this PR, since this library is out and many people are using it. It would be difficult until or unless we have mention these changes as breaking changes and release a major version. |
||
| }).then((data) => { | ||
| console.log(data); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| const Ebay = require('../src/index'); | ||
| const { clientId, clientSecret } = require('./credentials/index'); | ||
|
|
||
| let ebay = new Ebay({ | ||
| clientID: clientId, | ||
| clientSecret: clientSecret, | ||
| }); | ||
|
|
||
| ebay.getApplicationToken() | ||
| .then((data) => { | ||
| console.log(data); | ||
| if (!data.error) { | ||
| ebay.setAppAccessToken(data); | ||
| console.log(`App token: ${ebay.appAccessToken}`); | ||
| } | ||
| }); | ||
|
|
||
| setTimeout(() => { | ||
| ebay.getApplicationToken() | ||
| .then((data) => { | ||
| console.log(data); | ||
| if (!data.error) { | ||
| ebay.setAppAccessToken(data); | ||
| console.log(`App token: ${ebay.appAccessToken}`); | ||
| } | ||
| }); | ||
| }, 7200); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| const readline = require('readline'); | ||
| const Ebay = require('../src/index'); | ||
| const { clientId, clientSecret, redirectUri } = require('./credentials/index'); | ||
|
|
||
| let ebay = new Ebay({ | ||
| clientID: clientId, | ||
| clientSecret: clientSecret, | ||
| redirectUri: redirectUri, | ||
| }); | ||
|
|
||
| const rl = readline.createInterface({ | ||
| input: process.stdin, | ||
| output: process.stdout, | ||
| }); | ||
|
|
||
| const authURL = ebay.getUserAuthorizationUrl(); | ||
| console.log(`Please go here for auth code: ${authURL}`); | ||
| rl.question("Enter the auth code recieved from the redirect url: ", code => { | ||
| rl.close(); | ||
| ebay.getAccessTokenByCode(code).then(data => { | ||
| console.log(data); | ||
| if (!data.error) { | ||
| ebay.setUserAccessToken(data); | ||
| console.log(`User token: ${ebay.userAccessToken}\nRefresh token: ${ebay.refreshToken}`); | ||
| } | ||
| }) | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we keep name as
getAccessTokensince we are using this convention from the start ?.