Ship the MIT license with the legacy Action entrypoint - #38
Closed
paladini wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome: publisher-side license files do not fix the report
This PR tested the proposed direct fix for #29 by placing the repository's MIT license inside
action/and referencing that exact commit throughpaladini/harness-score/action@<SHA>.The real Dependency Review run still reported the legacy Action dependency as having an unknown license:
action/LICENSE: https://github.com/paladini/harness-score/actions/runs/30170660005v1.3.3: https://github.com/paladini/harness-score/actions/runs/30170681992The root test also reported
actions/checkout@v4as unknown. This indicates that the license result is coming from GitHub's Dependency Graph/Dependency Review metadata and is not changed by adding a license alongside the Action manifest.The local implementation itself was healthy (236 tests, lint, docs build, L4 108/108), but the proposed change did not meet its acceptance criterion. The PR is therefore closed without merge or release. Temporary validation workflows remain only in the closed branch history and were never merged into
main.