Fix sticky dark header contrast - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hs-header-papertoken through VitePress's--vp-nav-bg-colorRoot cause
VitePress removes the
.topclass from the home navigation after scrolling. Its more-specific sticky navigation selector then reapplies the dark--vp-nav-bg-color, while the Harness Score wordmark, navigation links, and controls retain their dark ink colors.By setting VitePress's navigation background token to the existing Harness Score paper color, the built-in top, sticky, sidebar, and mobile states all resolve to the intended header background without new specificity overrides or
!importantdeclarations.Browser verification
Verified locally with Playwright:
scrollY=600In the reported desktop dark-mode scenario, the sticky header now remains
rgb(241, 244, 236)with the wordmark and main links atrgb(13, 27, 23).Validation
npm run docs:buildnpm test— 268 tests passednpm run lint— passed with 18 pre-existing warnings and no errorsnpm run scan -- --min-level 4— L4, 108/108git diff --check