This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
improvement: Remove resource reservation cache and instead just use a store backed by a lister #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexis-D
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Overall seems like a good idea (and would allow us to revert the #262 hack), but unless I'm missing something won't this lead to a situation where we create an rr, we silently timeout trying to see that update, then later on we fail to see that rr because we're lagging behind?
(i guess you could argue that we already have this issue when running multiple spark scheduler nodes anyway?)
|
|
||
| func (d *defaultStore) allowListerToSync(ctx context.Context, result *v1beta2.ResourceReservation) { | ||
| ticker := time.NewTicker(time.Millisecond * 20) | ||
| ctx, cancel := context.WithDeadline(ctx, time.Now().Add(time.Second*5)) |
There was a problem hiding this comment.
Suggested change
| ctx, cancel := context.WithDeadline(ctx, time.Now().Add(time.Second*5)) | |
| ctx, cancel := context.WithTimeout(ctx, time.Second*5) |
| return err | ||
| } | ||
|
|
||
| func (d *defaultStore) allowListerToSync(ctx context.Context, result *v1beta2.ResourceReservation) { |
There was a problem hiding this comment.
what are the potential unintended consequences on this failing silently, should this return an error at least?
| return err | ||
| } | ||
| d.allowListerToSync(ctx, result) | ||
| return err |
There was a problem hiding this comment.
Suggested change
| return err | |
| return nil |
| return err | ||
| } | ||
| d.allowListerToSync(ctx, result) | ||
| return err |
There was a problem hiding this comment.
Suggested change
| return err | |
| return nil |
| return rrm.resourceReservations.Get(namespace, appID) | ||
| func (rrm *ResourceReservationManager) GetResourceReservation(ctx context.Context, appID string, namespace string) (*v1beta2.ResourceReservation, bool) { | ||
| r, err := rrm.resourceReservationStore.Get(ctx, namespace, appID) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| return r, err == nil |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?