-
Notifications
You must be signed in to change notification settings - Fork 68
Format annotated fields in records #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
|
||
public record QuoteRequest( | ||
int value, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty lines are kept in the output, so if people decide to add a line between the parameters, the formatter won't remove them
@Deprecated | ||
@JsonValue(name = "something") | ||
@Schema(description = "US state of the product being quoted", example = "TX") | ||
RegulatoryState regulatoryState, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new lines before & after the broken annotated field
Before this PR
Annotated fields in records would be formatted the same as the annotated arguments of methods.
While this makes sense for annotated arguments of methods (reasoning in: here) for record parameters, it makes them hard to read:
After this PR
Fixes: #922
Fixes: #1292
We are now reformatting the annotated parameters in records only following the rules:
==COMMIT_MSG==
Format annotated fields in records
==COMMIT_MSG==
Possible downsides?