Fix outdated Develop section in README#212
Merged
potiuk merged 2 commits intopallets-eco:mainfrom Mar 19, 2026
Merged
Conversation
…ize development setup instructions
Contributor
Author
|
By any chance the Python 3.9 CI/CD tests are being run with Python 3.12? |
potiuk
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Develop this package" section was outdated and contained references to files that no longer exist.
I did the minimal setup locally following the old documentation, the github action
Publish.ymland a bit of the dockerfiles. I think I got to something that's quite easy, and it's probably going to work for most people.I'm new to uv so if anything doesn't make sense, please let me know.
I have to say that the release section is still wrong, but I didn't touch it because I'm not sure if it's still being used or not (maybe it can be deleted or rewriten to reflect the current release process). In any case, I believe the standard is to use a virtual environment named
.venvand not venv3. That alone would break therelease.shscript.Oh, and at first I tried doing the full setup with Python 3.9, and it failed due to
hatchlingrequirements, but it's possible to only sync the tox group, and all the tests pass, so I guess the library can be used with Python 3.9.Solves #211