Skip to content

Fix typing for abort to accept Response object #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
touilleMan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typing for abort to accept Response object #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/quart/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ def _split_blueprint_path(name: str) -> List[str]:
return bps


def abort(code: int, *args: Any, **kwargs: Any) -> NoReturn: # type: ignore[misc]
def abort(code: int | Response, *args: Any, **kwargs: Any) -> NoReturn:
Copy link
Member

@pgjones pgjones Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Werkzeug's aborter can accept a Quart Response. I think this part of the API is unhelpful - what use case do you have in mind?

"""Raise an HTTPException for the given status code."""
if current_app:
current_app.aborter(code, *args, **kwargs)
Expand Down