fix: ante handler skip condition #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
After more investigation, it's become apparent that there are transactions which are being rejected in the CometBFT mempool, I don't think they ever reach the app mempool.
The reason for the rejection is the account sequence mismatch. Theoretically, this should be verified when submitting a transaction.
Looking at the code, there is a precondition in our ante handler for signature verification that's being skipped if we're running
CheckTX- so it's possible for a transaction that would actually fail to still be included in the mempool, as it looks like the check is only run once the TX is actually executed.Tested this in public test net against a dev build and had promising results, meaning most TXs got rejected and evicted during the
CheckTXstage.However, 6 transactions remain to be stuck. I'm not entirely sure why. It's possible they're being re-broadcasted from the other nodes. Once all validators upgrade to the next version with this change in place, we will know.
Testing completed
Breaking changes