chore: reduce consensus msg lifetime #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the lifetime of a consensus message to 300 blocks, approximately 8 minutes with an average block speed of 1.6 seconds per block. Before automatic reassignment of messages, a message would stay in the queue for up to 1200 blocks, giving the assigned validator some time to fix ongoing issues. With the reassignment of tardy messages in place, there's no need for messages to stay around considerably longer than 100 blocks really, but with 300 blocks we still get some opportunity to inspect what's going on in logs. We can reduce this value further to something like 100 or even 50 once we're confident with our relay stability.
|
Why not 5 minutes? does it matter? |
The longer message stay in the queue, the easier it is for us to debug ongoing issues in production. Once they're gone, it becomes more difficult. In theory though, we should have a lot of intel in the logs by now. So once I see this working as expected, I believe we can lower it considerably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Changes the lifetime of a consensus message to 300 blocks, approximately 8 minutes with an average block speed of 1.6 seconds per block.
Before automatic reassignment of messages, a message would stay in the queue for up to 1200 blocks, giving the assigned validator some time to fix ongoing issues.
With the reassignment of tardy messages in place, there's no need for messages to stay around considerably longer than 100 blocks really, but with 300 blocks we still get some opportunity to inspect what's going on in logs.
We can reduce this value further to something like 100 or even 50 once we're confident with our relay stability.
Testing completed
Breaking changes