Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attest turnstone messages #1259

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

maharifu
Copy link
Contributor

Background

Adapt turnstone message attestation test code to the new compass ABI.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@maharifu maharifu requested a review from byte-bandit August 13, 2024 12:18
byte-bandit
byte-bandit previously approved these changes Aug 13, 2024
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to leave a comment for future generations as to why we're doing this.

@maharifu maharifu force-pushed the fix/attest_turnstone_messages branch from b45ef89 to 8d65df8 Compare August 13, 2024 13:12
@maharifu maharifu merged commit 51b87b7 into palomachain:dev16 Aug 13, 2024
4 checks passed
@maharifu maharifu deleted the fix/attest_turnstone_messages branch August 13, 2024 13:20
maharifu added a commit that referenced this pull request Aug 16, 2024
# Background

Adapt turnstone message attestation test code to the new compass ABI.

# Testing completed

- [x] test coverage exists or has been added/updated
- [ ] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.

---------

Co-authored-by: Christian Lohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants